Normalize listener subscriptions on missing/future streams #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
condron
changed the title
condron
force-pushed
the
listen_to_future_streams
branch
from
1b63cbb to
bba276e
Compare
joshkempner
reviewed
Dec 9, 2024
|
@joshkempner the updated ESE version should be ready shortly |
condron
force-pushed
the
listen_to_future_streams
branch
from
c59ef7f to
96098c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The embedded Event Store implementation changes handing of missing streams, throwing on missing stream reads, like the ones used to validate subscriptions in the Listener implementations.
The non-embedded ES implementation does not throw when reading missing streams in for admin users. Admin DB users are the default mode for most connections using R-D.
To best preserve existing patterns in existing code bases the PR therefore makes stream validation optional and defaults to opt-in.
Includes a breaking change to
IListener.Start.